[lfs-dev] chapter05/expect.xml

Bruce Dubbs bruce.dubbs at gmail.com
Fri Jul 10 20:16:49 PDT 2015

Milton Ott wrote:

> Thanks for replying. I allowed my email client to reformat the patch
> I sent and only noticed it when checking the mailing list archive. In
> hindsight I should of just introduced myself . My one and only chance
> at making a good first impression is gone now. I guess I tried too
> hard to and ended up doing the opposite. Such is life I guess.

No problem.  The effort was noticed.

> For posterity if nothing else here is the patch proper.
> ---
> chapter05/expect.xml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> Index: LFS-20150628-systemd/chapter05/expect.xml
> ===================================================================
> --- LFS-20150628-systemd.orig/chapter05/expect.xml
> +++ LFS-20150628-systemd/chapter05/expect.xml
> @@ -46,8 +46,7 @@
>      This will ensure that our test suite tools remain sane for the
> final builds of our
>      toolchain:</para>
> -<screen><userinput remap="pre">cp -v configure{,.orig}
> -sed 's:/usr/local/bin:/bin:' configure.orig > configure</userinput></screen>
> +<screen><userinput remap="pre">sed -i.orig 's:/usr/local/bin:/bin:'
> configure</userinput></screen>
>      <para>Now prepare Expect for compilation:</para>

Actually for things that small, I just prefer email text.  A patch for a 
two line change is overkill.  I can make the change faster in vim than 
in applying the patch.  For instance:

In chapter05/expect.xml, change

cp -v configure{,.orig}
sed 's:/usr/local/bin:/bin:' configure.orig > configure


sed -i.orig 's:/usr/local/bin:/bin:' configure

Other projects will have different preferences.

> I've sent a small paypal donation using the donation button. Tx ID
> 7F129456J6536140J

I'm sure Gerard will appreciate that. Generally we are self funded.

   -- Bruce

More information about the lfs-dev mailing list