[lfs-dev] headers_check : should we drop it ?
zarniwhoop at ntlworld.com
Mon Mar 31 13:29:40 PDT 2014
On Sun, Mar 09, 2014 at 07:39:55PM -0500, Bruce Dubbs wrote:
> Ken Moffat wrote:
> > Should we just drop this command ?
> Perhaps we should. What is happening is that scripts/headers_check.pl
> is being run. The comments say:
> # Usage: headers_check.pl dir arch [files...]
> # dir: dir to look for included files
> # arch: architecture
> # files: list of files to check
> # The script reads the supplied files line by line and:
> # 1) for each include statement it checks if the
> # included file actually exists.
> # Only include files located in asm* and linux* are checked.
> # The rest are assumed to be system include files.
> # 2) It is checked that prototypes does not use "extern"
> # 3) Check for leaked CONFIG_ symbols
> Both soundcard.h and kexec.h violate #2. I don't believe these have
> ever caused a problem and we certainly don't address teh warnings.
> -- Bruce
I see you did this as part of r10508, but only in chapter 6.
Thanks for picking it up (I didn't spot it from looking the changelog
at the time). I can do chapter 5 if you like, but you've go so much
else going on in your reworking that I hesitate to touch it in case
I tread on your toes.
das eine Mal als Tragödie, dieses Mal als Farce
More information about the lfs-dev