grep 2.5.4 fmbtest test failure

Ken Moffat zarniwhoop73 at googlemail.com
Wed Mar 10 13:55:17 PST 2010


On 10 March 2010 20:36, Bruce Dubbs <bruce.dubbs at gmail.com> wrote:
> Ken Moffat wrote:
>> On 10 March 2010 19:37, Bruce Dubbs <bruce.dubbs at gmail.com> wrote:
>>> I downloaded grep_2.5.4-4.diff.gz and it applied without fuzz. Â All tests
>>> passed for me on both LFS-6.5 on a 64-bit system and an older 32-bit system.
>>>
>>> Â -- Bruce
>>>
>>  Sorry to be pedantic, but did you apply the patches from
>> debian/patches/ (as with all debian, they create patches
>> here and then apply them) ?
>
> No.  http://packages.debian.org/sid/grep which points to
> http://ftp.de.debian.org/debian/pool/main/g/grep/grep_2.5.4-4.diff.gz
>
>   -- Bruce
> --
 If you just applied that, then everything remains in the
debian/ directory and isn't applied to src/, see e.g. the
start of patch 60 :

--- grep-2.5.4.orig/debian/patches/60-dfa.c-case_fold.patch
+++ grep-2.5.4/debian/patches/60-dfa.c-case_fold.patch
@@ -0,0 +1,20 @@
+--- a/src/dfa.c.orig   2004-10-19 01:52:09.000000000 +0900
++++ b/src/dfa.c        2004-10-19 01:59:43.000000000 +0900
+@@ -547,6 +547,17 @@
+               /* build character class.  */
+               {
+                 wctype_t wt;
++                /* NOTE:
++                 * when case_fold, character class [:upper:] and [:lower:]


So, I'm back at not being able to produce a testcase that
shows a meaningful slowdown without the patch, because
I no longer have suitable test data, and it breaks tests
which (in 2.5.4) would otherwise succeed.

Unless someone with a large amount of multibyte text in
UTF-8 can provide some meaningful timings for why the
unpatched verson is a bad idea, or has real life examples
of the bugs debian are trying to fix, maybe we should just
drop that patch for 2.5.4.

Diffing the testsuite against grep-git (a waste of time,
I'm missing dependencies to be able to configure that),
I see that 2.5.4 seems to be using zh_CN in one of the tests
- but only noticed because that test has dropped out.

ĸen
-- 
After tragedy, and farce, "OMG poneys!"



More information about the lfs-dev mailing list