grep 2.5.4 fmbtest test failure

Ken Moffat zarniwhoop73 at googlemail.com
Tue Mar 9 16:43:44 PST 2010


On 9 March 2010 23:40, Bruce Dubbs <bruce.dubbs at gmail.com> wrote:

>
> Ken submitted the patch two years ago against grep 2.5.3.  The purpose
> of the patch was
>
> Description: Various fixes, particularly speed improvements for UTF-8
> locales. Also adds a 'standard input' marker into the results for
> certain obscure uses.

 I *vaguely* remember that in some particular test, perhaps on a very big
file, the unpatched grep was disgustingly slow in a UTF-8 locale, and that
patch seemed to fix it.  I also remember that fmbtest never used to work.
At one point there was some hackery upstream to get rid of failure reports
on tests that weren't expected to work at the moment.

 Unfortunately, my subscription to bug-grep was one of the things that
went when I lsot access to my old nthell mail, and I didn't notice.

 When I first saw this thread, I remembered nothing about it until Bruce
pointed out the patch had my name!

>
> ---
>
> The tests that fail are for
>
> # Test that --color=always does not depend on individual pattern order
> within the pattern
> # list, and that a longer match is preferred to a shorter one starting
> at the same point.
>
> test6="`echo 'Cosi tu Ä~LiÅ¡Ã~M...' \
>    | LC_ALL=cs_CZ.UTF-8 ${GREP} --color=always -${mode}i \
>      -e 'Ä~MiÅ¡' -e 'Ä~Miší'`"
> if echo "$test6" | LC_ALL=C ${GREP} -q 'Cosi tu
> .*\[.*m\(.\[K\)\?Ä~LiÅ¡Ã~M.*\[.*m\(.\[K\)\?\.\.\.'; then
>   :
> else
>   echo "Test #6 ${mode} failed: $test6"
>   failures=1
> fi
>
> where mode is F.
>
> A similar test fails for test7.
>
> ---------
>
> I downloaded the current debian patch and all tests pass against that
> patch.
>
> Ken, can you take a look at the new debian patch and create a new lfs
> patch for us that fulfills your intent?
>

 Added to my ToDo list.

ĸen
-- 
After tragedy, and farce, "OMG poneys!"



More information about the lfs-dev mailing list