One more addition to dependencies list

Bryan Kadzban bryan at kadzban.is-a-geek.net
Wed Oct 3 19:27:12 PDT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Bruce Dubbs wrote:
> Chris Staub wrote:
>> gzip <$? >$@
>> 
>> Everywhere else when it needs to use a program in the sourcedir, it
>> just uses the pathname..."./zdiff", "./zgrep", etc...and at the
>> end of the testsuite it does also use "./gzip".
> 
> Sounds like an error in the test script to me.  We ought to fix it in
> the book and send a patch upstream.

It might be intended.

If you're trying to test just the decompression part of zdiff (which is
presumably shared with gunzip?), then it makes sense to me to use the
assumed-good system gzip to build an assumed-good gzipped file.  Then
use the just-built decompression code, and compare the result with what
you started with.

If there was a "symmetric" bug in both the compression and decompression
sides of gzip, then using the just-built gzip would hide it.  As long as
the gzip file format never changes, it should be OK to use the system
gzip binary, I think.

(But it may be good to bring this up upstream anyway, just in case.)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBE9/S5vET1Wea5wRA/67AJ0dmeEWxtDVZnL5qwmdHtEOsPnvkwCaAg2h
EpcATNFfBiOo8/gCbkFBMzs=
=zXet
-----END PGP SIGNATURE-----



More information about the lfs-dev mailing list