Fixing Gawk's configure bugs

Dan Nicholson dbn.lists at gmail.com
Mon Apr 30 12:20:23 PDT 2007


On 4/30/07, Matthew Burgess <matthew at linuxfromscratch.org> wrote:
> On Monday 30 April 2007 02:44:34 Alexander E. Patrakov wrote:
>
> > This is just an undocumented side effect, and Gawk's configure.ac should
> > call the AM_LANGINFO_CODESET and gt_LC_MESSAGES macros explicitly instead
> > of relying upon this effect.
>
> Thanks very much Alexander.  Attached are two patches.  The first one is what
> I'll submit upstream.  It just contains the change to configure.ac to call
> the relevant functions which set HAVE_LC_MESSAGES and HAVE_LANGINFO_CODESET.
> The second is what I propose gets added to the book - it's the result
> of 'autoreconf -f' on the source tree after the first patch has been applied.
> Any objections?

Nice job on the upstream patch. It's not really a strong objection,
but I'm not crazy about applying a 15k patch when the issue can be
worked around in one command. I don't feel strongly enough to keep it
out, though, if that's what others want.

--
Dan



More information about the lfs-dev mailing list