[elinks-dev] [PATCH] fix mangled indentation in configure --help

Kamil Dudka kdudka at redhat.com
Wed Sep 10 01:37:22 PDT 2008


On Tuesday 09 September 2008 23:07:04 Kalle Olavi Niemitalo wrote:
> ELinks should be kept compatible with Autoconf 2.59, but if you
> add four pairs of square brackets for that, I think Autoconf 2.62
> will then include too many of them in the --help output.  So the
> right solution seems to be to avoid AC_HELP_STRING and instead
> align the strings by hand.  Alternatively, one could define
> EL_HELP_STRING, but that would probably require more effort than
> it'd save.
>
> The alignment and brackets are minor details.  If you feel they
> are costing too much time, I think it'd be enough to have the
> same level of correctness as in the preexisting options.
> I do not want the four pairs of square brackets though.
Well, removed AC_HELP_STRING from elinks-nss.patch as well...

> > +	if test -z "$with_nss_compat_ossl" -o "$with_nss_compat_ossl" = yes;
> > then
>
> The Autoconf manual advises against using the -a and -o operators
> of test, because of variations in precedence.  Instead:
>
> +	if test -z "$with_nss_compat_ossl" || test "$with_nss_compat_ossl" = yes;
> then
Also fixed, new patch in attachment...


Kamil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: elinks-nss.patch
Type: text/x-diff
Size: 10756 bytes
Desc: not available
URL: <http://lists.linuxfromscratch.org/pipermail/elinks-dev/attachments/20080910/707003f2/attachment.patch>


More information about the elinks-dev mailing list