[elinks-dev] contrib/bzip2-pipe.patch

Witold Filipczyk witekfl at poczta.onet.pl
Sat Jan 6 03:39:52 PST 2007


On Sat, Jan 06, 2007 at 10:12:15AM +0200, Kalle Olavi Niemitalo wrote:
> I was going to ask the bzip2 maintainer whether bzip2-pipe.patch
> would have any chance of getting in, but then I noticed that bug
> 517 already has an attached patch (attachment 271) that makes
> ELinks use BZ2_bzDecompress instead of BZ2_bzRead, so that it can
> handle the EAGAIN errors on its own.  I am sorry to reject
> bzip2-pipe.patch after you've spent time on it, but I believe
> changing ELinks to use BZ2_bzDecompress would be better for users
> because it does not require any changes in libbz2, cannot break
> other programs, and relies only on the published API of libbz2.

I agree.

> 
> Could you perhaps test the patch in
> <http://bugzilla.elinks.cz/attachment.cgi?id=271> and report or
> even fix any problems you find in it?  It could then be included
> in ELinks 0.12.0, I think.

It works.

In decompress_data writing to the pipe PIPE_BUF / 2 bytes at most is
no longer necessary. Likewise reading PIPE_BUF / 32 on init.
This is fixed on my branch.



More information about the elinks-dev mailing list