[elinks-dev] Re: elinks - jonas: Fix compilation failure spotted by zas.

Petr Baudis pasky at ucw.cz
Tue Jun 22 04:42:30 PDT 2004


Dear diary, on Tue, Jun 08, 2004 at 12:54:22PM CEST, I got a letter,
where cvs at pasky.or.cz told me, that...
> This is an automated notification of a change to the ELinks CVS tree.
> 
> Author: jonas
> Module: elinks
>    Tag: <TRUNK>
>   Date: Tue Jun  8 10:54:22 2004 GMT
> 
> ---- Log message:
> 
> Fix compilation failure spotted by zas.
> 
> 
> ---- Files affected:
> 
> elinks/src/scripting/lua:
>    hooks.c (1.52 -> 1.53) 
>     http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/scripting/lua/hooks.c.diff?r1=1.52&r2=1.53&f=u
> 
> 
> ---- Diffs:
> 
>  elinks/src/scripting/lua/hooks.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Index: elinks/src/scripting/lua/hooks.c
> diff -u elinks/src/scripting/lua/hooks.c:1.52 elinks/src/scripting/lua/hooks.c:1.53
> --- elinks/src/scripting/lua/hooks.c:1.52	Mon Jun  7 17:58:07 2004
> +++ elinks/src/scripting/lua/hooks.c	Tue Jun  8 12:54:17 2004
> @@ -44,7 +44,7 @@
>  		lua_pushstring(L, struri(current_uri));
>  	}
>  
> -	if (prepare_lua(ses)) return EHS_NEXT;
> +	if (prepare_lua(NULL)) return EHS_NEXT;
>  
>  	err = lua_call(L, 2, 1);
>  	finish_lua();

Then potential error reporting is broken, because Lua cannot open
window.

All the event hooks should therefore receive (struct session *) - they
can get the current URI as well as other possibly useful data, like that
terminal for showing errors etc.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A, B, C, D, E, F, G... I will eat your family.  -- Dane Cook



More information about the elinks-dev mailing list