[elinks-dev] Re: [ELinks] elinks - pasky: Revert zas' 1.419, dropping some 'useless...

Zas zas at norz.org
Tue Jun 22 00:43:52 PDT 2004


On Tue, Jun 22, 2004 at 12:50:57AM -0000, ELinks cvs wrote:
> This is an automated notification of a change to the ELinks CVS tree.
> 
> Author: pasky
> Module: elinks
>    Tag: <TRUNK>
>   Date: Tue Jun 22 00:50:57 2004 GMT
> 
> ---- Log message:
> 
> Revert zas' 1.419, dropping some 'useless' blank lines. I could also imagine a line I could drop... :E
> CCMAIL: zas at norz.org
> 
> 
> ---- Files affected:
> 
> elinks/src/document/html:
>    parser.c (1.439 -> 1.440) 
>     http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/document/html/parser.c.diff?r1=1.439&r2=1.440&f=u
> 
> 
> ---- Diffs:
> 
>  elinks/src/document/html/parser.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+)
> 
> 
> Index: elinks/src/document/html/parser.c
> diff -u elinks/src/document/html/parser.c:1.439 elinks/src/document/html/parser.c:1.440
> --- elinks/src/document/html/parser.c:1.439	Sun Jun 20 23:19:29 2004
> +++ elinks/src/document/html/parser.c	Tue Jun 22 02:50:51 2004
> @@ -931,6 +931,10 @@
>  	mem_free(rows);
>  }
>  
> +
> +
> +
> +

What is wrong with these ? Please describe why these are useful.


>  void
>  process_head(unsigned char *head)
>  {
> @@ -959,6 +963,9 @@
>  	}
>  }
>  
> +
> +
> +
What is wrong with these ? Please describe why these are useful.


>  static int
>  look_for_map(unsigned char **pos, unsigned char *eof, struct uri *uri)
>  {
> @@ -1180,6 +1187,7 @@
>  	return 1;
>  }
>  
> +
What is wrong with this one ? Please describe why this one is useful.

>  int
>  get_image_map(unsigned char *head, unsigned char *pos, unsigned char *eof,
>  	      struct menu_item **menu, struct memory_list **ml, struct uri *uri,
> @@ -1218,6 +1226,9 @@
>  	return 0;
>  }
>  
> +
> +
> +
What is wrong with these ? Please describe why these are useful.


>  struct html_element *
>  init_html_parser_state(enum html_element_type type, int align, int margin, int width)
>  {
> @@ -1241,6 +1252,8 @@
>  	return element;
>  }
>  
> +
> +
What is wrong with these ? Please describe why these are useful.


>  void
>  done_html_parser_state(struct html_element *element)
>  {
> 


If you want to separate functions that are unrelated, just insert a
comment, or move them in another file.
Imho, blank lines meaning is unclear for most people. Why should we
have 2, 3, 4, or more lines there and not there ?

-- 

Zas



More information about the elinks-dev mailing list