[elinks-dev] Re: elinks - zas: Tidy up and improved comments.

Petr Baudis pasky at ucw.cz
Mon Jun 21 16:19:43 PDT 2004


Dear diary, on Fri, Jun 18, 2004 at 11:30:32AM CEST, I got a letter,
where cvs at pasky.or.cz told me, that...
> This is an automated notification of a change to the ELinks CVS tree.
> 
> Author: zas
> Module: elinks
>    Tag: <TRUNK>
>   Date: Fri Jun 18 09:30:32 2004 GMT
> 
> ---- Log message:
> 
> Tidy up and improved comments.
> 
> 
> ---- Files affected:
> 
> elinks/src/protocol/smb:
>    smb.c (1.46 -> 1.47) 
>     http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/protocol/smb/smb.c.diff?r1=1.46&r2=1.47&f=u
> 
> 
> ---- Diffs:
> 
>  elinks/src/protocol/smb/smb.c |   46 +++++++++++++++++++---------------
>  1 files changed, 27 insertions(+), 19 deletions(-)
> 
> 
> Index: elinks/src/protocol/smb/smb.c
> diff -u elinks/src/protocol/smb/smb.c:1.46 elinks/src/protocol/smb/smb.c:1.47
> --- elinks/src/protocol/smb/smb.c:1.46	Fri Jun 18 11:13:41 2004
> +++ elinks/src/protocol/smb/smb.c	Fri Jun 18 11:30:27 2004
..snip..
>  		execvp(SMBCLIENT, (char **) v);
>  
> +		/* FIXME: this message will never be displayed, since execvp()
> +		 * failed. */
>  		fprintf(stderr,  SMBCLIENT " not found in $PATH");
>  		_exit(1);
>  #undef MAX_SMBCLIENT_ARGS

I'm sorry but I don't understand this. Since execvp() failed, this
message _will_ be displyed, won't it?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A, B, C, D, E, F, G... I will eat your family.  -- Dane Cook



More information about the elinks-dev mailing list