[blfs-book] [BLFS Trac] #12067: xine-lib is reported to not build against alsa-lib-1.1.9

BLFS Trac trac at linuxfromscratch.org
Thu May 16 13:27:45 PDT 2019


#12067: xine-lib is reported to not build against alsa-lib-1.1.9
-------------------------+------------------------
 Reporter:  ken@…        |       Owner:  blfs-book
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  8.5
Component:  BOOK         |     Version:  SVN
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------

Old description:

> From the xine-devel list (reformatted with added blank lines to try to
> stop trac making it totally unreadable)
>
> # HG changeset patch
>
> # User Xavier Bachelot <xavier at bachelot.org>
>
> # Date 1557995649 -7200
>
> #      Thu May 16 10:34:09 2019 +0200
>
> # Node ID 673f6f42def382d02c6b75cfbce030f52e1bdaae
>
> # Parent  a7e3e6825a9669e277965c1e6ab479cbfda04b0b
>
> Fix alsa headers include path
>
> alsa-lib 1.1.9 has changed the include paths in its pkgconfig to disallow
> the
> use of straight asoundlib.h in favor of the canonical alsa/asounlib.h.
> See for details:
> https://www.alsa-
> project.org/wiki/Detailed_changes_v1.1.8_v1.1.9#.2Finclude.2FMakefile.am
>
> diff -r a7e3e6825a96 -r 673f6f42def3 src/audio_out/audio_alsa_out.c
> --- a/src/audio_out/audio_alsa_out.c    Wed May 15 17:34:15 2019 +0200
> +++ b/src/audio_out/audio_alsa_out.c    Thu May 16 10:34:09 2019 +0200
> @@ -44,7 +44,7 @@
>
>  #define ALSA_PCM_NEW_HW_PARAMS_API
>
>  #define ALSA_PCM_NEW_SW_PARAMS_API
>
> -#include <asoundlib.h>
>
> +#include <alsa/asoundlib.h>
>

>  #include <sys/ioctl.h>
>
>  #include <inttypes.h>
>

> I'm sure we can use a sed for that (I don't have 1.1.9 at the moment).

New description:

 From the xine-devel list (reformatted with added blank lines to try to
 stop trac making it totally unreadable)

 {{{
 # HG changeset patch
 # User Xavier Bachelot <xavier at bachelot.org>
 # Date 1557995649 -7200
 #      Thu May 16 10:34:09 2019 +0200
 # Node ID 673f6f42def382d02c6b75cfbce030f52e1bdaae
 # Parent  a7e3e6825a9669e277965c1e6ab479cbfda04b0b
 }}}

 Fix alsa headers include path

 alsa-lib 1.1.9 has changed the include paths in its pkgconfig to disallow
 the
 use of straight asoundlib.h in favor of the canonical alsa/asounlib.h.
 See for details:
 https://www.alsa-
 project.org/wiki/Detailed_changes_v1.1.8_v1.1.9#.2Finclude.2FMakefile.am

 {{{
 diff -r a7e3e6825a96 -r 673f6f42def3 src/audio_out/audio_alsa_out.c
 --- a/src/audio_out/audio_alsa_out.c    Wed May 15 17:34:15 2019 +0200
 +++ b/src/audio_out/audio_alsa_out.c    Thu May 16 10:34:09 2019 +0200
 @@ -44,7 +44,7 @@
  #define ALSA_PCM_NEW_HW_PARAMS_API
  #define ALSA_PCM_NEW_SW_PARAMS_API
 -#include <asoundlib.h>
 +#include <alsa/asoundlib.h>
  #include <sys/ioctl.h>
  #include <inttypes.h>
 }}}

 I'm sure we can use a sed for that (I don't have 1.1.9 at the moment).

--

Comment (by bdubbs):

 Use triple { construct to get literal trac text.

 I just built xine-lib without issue.  Looking at /usr/include, there still
 is asoundlib.h, but it's contents are:

 {{{
 $ cat asoundlib.h
 #warning This header is deprecated, use <alsa/asoundlib.h> instead.
 #include <alsa/asoundlib.h>
 }}}

 I don't think a change is needed at this time.  This should be worksforme,
 but I'll hold off for now.

--
Ticket URL: <http://wiki.linuxfromscratch.org/blfs/ticket/12067#comment:1>
BLFS Trac <http://wiki.linuxfromscratch.org/blfs>
Beyond Linux From Scratch


More information about the blfs-book mailing list